[Gtk-sharp-list] parameter type incorrect?

John Luke jluke@users.sourceforge.net
Mon, 05 Jan 2004 14:37:47 -0500


--=-qmWOojgtJ8DqlxhOtJkb
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Sun, 2004-01-04 at 23:28 -0700, Seth Kurtzberg wrote:
> All,
> 
> Should the type of the key argument of Gtk.AddAccelerator be Gdk.Key 
> instead of uint?
Hello,
Attached is a patch to have it accept a Gtk.AccelKey instead of uint.  I
will look into adding an overload for Gdk.Key also.
Ok to commit?

--=-qmWOojgtJ8DqlxhOtJkb
Content-Disposition: attachment; filename=widget_gtkaccelkey.diff
Content-Type: text/x-patch; name=widget_gtkaccelkey.diff; charset=UTF-8
Content-Transfer-Encoding: 7bit

? button.diff
? gdk_key.diff
? test.diff
? widget_gtkaccelkey.diff
Index: Gtk.metadata
===================================================================
RCS file: /cvs/public/gtk-sharp/gtk/Gtk.metadata,v
retrieving revision 1.18
diff -u -r1.18 Gtk.metadata
--- Gtk.metadata	31 Dec 2003 02:10:08 -0000	1.18
+++ Gtk.metadata	5 Jan 2004 19:20:05 -0000
@@ -259,6 +259,7 @@
   <attr path="/api/namespace/object[@cname='GtkWidget']/signal[@name='SizeRequest']" name="name">SizeRequested</attr>
   <attr path="/api/namespace/object[@cname='GtkWidget']/signal[@name='Unmap']" name="name">Unmapped</attr>
   <attr path="/api/namespace/object[@cname='GtkWidget']/signal[@name='Unrealize']" name="name">Unrealized</attr>
+  <attr path="/api/namespace/object[@cname='GtkWidget']/method[@name='AddAccelerator']/parameters/parameter[@name='accel_key']" name="type">GtkAccelKey</attr>
   <attr path="/api/namespace/object[@cname='GtkWindow']/method[@name='GetDefaultSize']/*/*[@type='gint*']" name="pass_as">out</attr>
   <attr path="/api/namespace/object[@cname='GtkWindow']/method[@name='GetPosition']/*/*[@type='gint*']" name="pass_as">out</attr>
   <attr path="/api/namespace/object[@cname='GtkWindow']/method[@name='GetSize']/*/*[@type='gint*']" name="pass_as">out</attr>
Index: gtk-api.xml
===================================================================
RCS file: /cvs/public/gtk-sharp/gtk/gtk-api.xml,v
retrieving revision 1.26
diff -u -r1.26 gtk-api.xml
--- gtk-api.xml	31 Dec 2003 02:10:08 -0000	1.26
+++ gtk-api.xml	5 Jan 2004 19:20:06 -0000
@@ -9893,7 +9893,7 @@
         <parameters>
           <parameter type="const-gchar*" name="accel_signal" />
           <parameter type="GtkAccelGroup*" name="accel_group" />
-          <parameter type="guint" name="accel_key" />
+          <parameter name="accel_key" type="GtkAccelKey" />
           <parameter type="GdkModifierType" name="accel_mods" />
           <parameter type="GtkAccelFlags" name="accel_flags" />
         </parameters>
@@ -13294,4 +13294,4 @@
       <static-string cname="GTK_STOCK_ZOOM_OUT" name="ZoomOut" value="gtk-zoom-out" />
     </object>
   </namespace>
-</api>
\ No newline at end of file
+</api>

--=-qmWOojgtJ8DqlxhOtJkb--