[Gtk-sharp-list] [PATCH] ThreadNotify
Gonzalo Paniagua Javier
gonzalo@ximian.com
Fri, 17 Oct 2003 22:05:04 +0200
El vie, 17-10-2003 a las 21:23, Mike Kestner escribió:
> On Fri, 2003-10-17 at 12:28, Gonzalo Paniagua Javier wrote:
> > We are leaking the 2 fds of the pipe and the GSource created in
> > gdk_input_add (ThreadNotify.cs).
> >
> > The attached patch adds Close (), IDisposable pattern and a finalizer to
> > ThreadNotify.
>
> Looks like disposed isn't initialized.
No need to initialize that one. It will be false.
>
> > Ok to commit?
>
> Yeah, please, with the above comment resolved. Thanks for the patch.
Done. I added a GC.SuppressFinalize that was missing.
-Gonzalo