[Gtk-sharp-list] Various enhancements to GnomePrint patch

Martin Willemoes Hansen mwh@sysrq.dk
Wed, 08 Oct 2003 10:42:08 +0200


--=-4IQRwpP4Mk3NCELGDaVw
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Tue, 2003-10-07 at 17:08, Mike Kestner wrote:

> On Tue, 2003-10-07 at 06:43, Martin Willemoes Hansen wrote:
> 
> > Oh yes, im no C expert, but I would like to be. Here is the C
> > function.
> > 
> > gnome-print-config.c
> > guchar *
> > gnome_print_config_get (GnomePrintConfig *config, const guchar *key)
> 
> They aren't marking it const, so we shouldn't unless we start seeing
> crashes from freeing the string it returns.



Okay.


> > Finally I have a new patch incorporating the changes mentioned above.
> 
> Go ahead and commit it after changing that return-val to gchar* without
> the const-.  Also, I know you marked a bunch of other strings a week or
> so ago, can you make sure those aren't marked const if the native api
> doesn't identify them as const?



Committed.

Btw, I saw you have place gtkhtml-api.xml in gtk-sharp/gtkhtml/ instead
of api/gtkhtml  .. why is that?

-- 
Martin Willemoes Hansen

--------------------------------------------------------
E-Mail	mwh@sysrq.dk	Website	mwh.sysrq.dk
IRC     MWH, freenode.net
--------------------------------------------------------               


--=-4IQRwpP4Mk3NCELGDaVw
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
  <META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
  <META NAME="GENERATOR" CONTENT="GtkHTML/3.0.9">
</HEAD>
<BODY>
On Tue, 2003-10-07 at 17:08, Mike Kestner wrote:
<BLOCKQUOTE TYPE=CITE>
<PRE><FONT COLOR="#737373"><I>On Tue, 2003-10-07 at 06:43, Martin Willemoes Hansen wrote:

&gt; Oh yes, im no C expert, but I would like to be. Here is the C
&gt; function.
&gt; 
&gt; gnome-print-config.c
&gt; guchar *
&gt; gnome_print_config_get (GnomePrintConfig *config, const guchar *key)

They aren't marking it const, so we shouldn't unless we start seeing
crashes from freeing the string it returns.</PRE>
</BLOCKQUOTE>
<PRE></I></FONT></PRE>
Okay.<BR>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE><FONT COLOR="#737373"><I>&gt; Finally I have a new patch incorporating the changes mentioned above.

Go ahead and commit it after changing that return-val to gchar* without
the const-.  Also, I know you marked a bunch of other strings a week or
so ago, can you make sure those aren't marked const if the native api
doesn't identify them as const?</PRE>
</BLOCKQUOTE>
<PRE></I></FONT></PRE>
Committed.<BR>
<BR>
Btw, I saw you have place gtkhtml-api.xml in gtk-sharp/gtkhtml/ instead of api/gtkhtml&nbsp; .. why is that?
<PRE><TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
<PRE>-- 
Martin Willemoes Hansen

--------------------------------------------------------
E-Mail	mwh@sysrq.dk	Website	mwh.sysrq.dk
IRC     MWH, freenode.net
--------------------------------------------------------               
</PRE>
</TD>
</TR>
</TABLE>
</PRE>
</BODY>
</HTML>

--=-4IQRwpP4Mk3NCELGDaVw--