[Gtk-sharp-list] TreeView.ScrollToCell bug/patch

Mike Kestner mkestner@speakeasy.net
24 Mar 2003 22:57:41 -0600

Hi Lee,  Thanks for the patch.

On Mon, 2003-03-24 at 11:50, Lee Mallabone wrote:

> This call allows one of 2 of its parameters to be null. However, the
> auto-generated method assumes both are non-null, making the method crash
> under certain (valid) circumstances.

Your patch will still crash if the user passes null for both
parameters.  I'm not sure if that is worth trying to catch.  I guess we
could throw an exception in that case.  

If we aren't going to be fascist about error checking like that, it
would probably be better to just mark both parameters with the null_ok
attribute via metadata and let the generator produce the null handling

> There are also a couple of GtkHTML changes in the patch - these are not
> intentional and I assume are just due to my source tree tracking the cvs
> version of gtkhtml?

Yeah. Now that gtkhtml-3.0 has released, we should start tracking
releases. For now, this is fine.

> Please let me know if the patch is 'commitable'.

With one of the above corrections, yes.  If you choose to stick with the
.custom, you can also kill the inline doc comment and just add them
directly to the ECMA-XML docs.

Thanks again for the patch.

Mike Kestner <mkestner@speakeasy.net>