[Gtk-sharp-list] gapi__pp.pl patch for striping out c comments
Martin Willemoes Hansen
mwh@sysrq.dk
24 Jun 2003 13:47:58 +0200
On Tue, 2003-06-24 at 06:31, Mike Kestner wrote:
> Thanks for the patch, Martin.
>
> On Sat, 2003-06-21 at 06:17, Martin Willemoes Hansen wrote:
>
> > I added stripping of // too.
>
> I'd suggest filing a bug report (preferably with patch) to any c library
> that is using // style comments. Some compilers let you do it, but it's
> a portability no-no.
Sure ill do that ..
> > Can I commit?
>
> Did you do a make in sources/ to see if anything changed in api/*.xml?
> The patch isn't showing any such changes, but I'd like to confirm this
> step was done, since you are making the change for an external lib and
> may not have thought to rerun the parser on Gtk#.
No, ill do that asap and return with the changes if any.
> If you haven't, and are willing to do the legwork, you could rework the
> patch to include the changes to api/ after making sources/ and resend it
> to me off list for review. If not, I'll be happy to do it, but I'm not
> sure when I will get to it, and the patch can't really be committed
> until this has been done.
Ill see to it be done .. expect a mail soon.
--
Martin Willemoes Hansen
--------------------------------------------------------
E-Mail mwh@sysrq.dk Website mwh.sysrq.dk
IRC MWH, freenode.net
--------------------------------------------------------