[Gtk-sharp-list] Point.custom patch
Mike Kestner
mkestner@speakeasy.net
05 Feb 2003 19:18:40 -0600
On Wed, 2003-02-05 at 14:05, Martin Willemoes Hansen wrote:
> Can it be included? I have not tested it since my cvs is not
> functioning.
Submitting untested patches for review is not a good idea. I'll be happy
to re-review the patch after you've tested it, though.
As far as the substance of the patch, I'm unsure of the utility provided
by the additional properties. Also, the need to instantiate a Gdk.Point
from an existing Gdk.Point escapes me, especially for a value type.
The public Point(int x, int y) ctor seems like a good addition.
> Also I was in doubt about the Author copyright lines, are they ok?
Yes, you are welcome to retain copyright and claim Authorship of any
contributions you make to Gtk#.
--
Mike Kestner <mkestner@speakeasy.net>