[Gtk-sharp-list] Patch for gdk/Pixbuf.custom

Martin Willemoes Hansen mwh@sysrq.dk
Thu, 28 Aug 2003 12:28:58 +0200

On Thu, 2003-08-28 at 04:40, Mike Kestner wrote:
> On Wed, 2003-08-27 at 02:53, Martin Willemoes Hansen wrote:
> > Umh I added a proper copyright/information header and fixed some long
> > method signatures.
> (This is probably going to sound like a rant, but please take it instead
> as an attempt to specify best practices for patch submittal.)

No problemo, it is good to hear.

> You didn't "fix" any method signatures.  You introduced whitespace
> changes into a patch that made it much more difficult to determine what
> the real changes are.  Whitespace changes like this also make it more
> difficult to use cvs history commands to determine when code was added
> and by whom.

I see your point.

> Please remove the whitespace changes from the patch and commit it.
> Thanks.

Martin Willemoes Hansen

E-Mail	mwh@sysrq.dk	Website	mwh.sysrq.dk
IRC     MWH, freenode.net