[Glade-devel] Re: New Icons

[Vincent Geddes]

On Thu, 2006-06-15 at 23:43 -0400, Tristan Van Berkom wrote:
> >Just one issue: All abstract widget classes like GtkWidget, GtkBox, and
> >GtkPaned, etc, are all trying to load icons, even though they shouldn't
> >have one. We need to think of how to solve this, as a lot "Missing Icon"
> >warnings are being logged as a result. The "widget_class->in_palette"
> >flag used to prevent this, but it has since been removed.
> >  
> >
> Err, well "in_palette" isnt enough, menuitems need icons but
> are not in the palette... the correct conditions to load an icon
> is something like:
> 
>     if (G_TYPE_IS_INSTANTIATABLE (widget_class->type)    &&
>         G_TYPE_IS_ABSTRACT (widget_class->type) == FALSE)
> 
> Also, any widget class that has a "generic_name" should have
> an icon.
> 

Hi,

Thanks for the solution, it does the trick!

Also, since glade seems to be nearing release time, I think we should
phase out the logging of "Missing Icon" warnings. 

I reason that many Gtk+ developers will not want to spend time creating
icons for their custom widget catalogs. Some developers might not be
very artistically inclined, or are only creating a custom catalog for a
short-term project. So I propose that we include a "default" or
"fallback" icon which will stand in for widgets with missing icons.

What do you think? Should I go ahead with this?

regards

Vincent