[Glade-devel] Re: strcmp in glade-xml-utils [was: ShortCuts]

[Juan Pablo Ugarte]

On Tue, 2005-09-13 at 10:52 -0400, Tristan Van Berkom wrote:
> Tristan Van Berkom wrote:
> [...]
> > Ahhh,
> >    that must be because of xmlChar definitions, from a glance at
> > the libxml2 docs, we need to be using the BAD_CAST macro for all
> > the const strings that are passed into the glade-xml-utils api
> > for comparisons... nice catch; gcc 4 is looking good ;-p
> > 
> 
> Created this:
>      http://bugzilla.gnome.org/show_bug.cgi?id=316201
> 
> I forgot to mention, on top of using BAD_CAST, we also need to
> use xmlStrcmp on the "xmlChar *"s, if you want to fix that that'd
> be great, otherwise I'll eventually get around to it :)

Yes, I will. I hate warnings :)

I already fix that, but what about when we need to cast a xmlChar into a
gchar as in claim_string() ?

We could define a new cast

#define CAST_BAD (gchar *)

there should be no big problem since gchar and xmlChar are both UTF-8
strings.

I really do not know what is the cleaner way to solve this:
 * leave everything as is it and use these casts everywhere they are
needed or
 * replace xmlChar to gchar and use wrapers for libxml functions

Comments are welcome :)

Juan Pablo


	

	
		
___________________________________________________________ 
1GB gratis, Antivirus y Antispam 
Correo Yahoo!, el mejor correo web del mundo 
http://correo.yahoo.com.ar