[Glade-devel] [glade 3] Dont save packing when not needed [PATCH]

[Shane Butler]

--Boundary_(ID_Ccn2M7djz72KKzkQS+ClVQ)
Content-type: text/plain
Content-transfer-encoding: 7BIT

Dear Joaquin,

I noticed this extra packing tag when comparing glade-2 and glade-3
files, so I assumed that since glade-2 does it, that it would work ok
with libglade.  Is this sufficient?  Otherwise I will test as you
suggested.

Regards, Shane

PS. Simple glade files featuring a window with a button are attached as
an example.

On Fri, 2004-05-21 at 08:03, Joaquin Cuenca Abela wrote:
>  Shane wrote:
> > 
> > Hi all,
> > 
> > I have attached a patch that stops Glade 3 from saving the 
> > empty <packing/> tag for widgets where it is not needed :)
> 
> Hi Shane,
> 
> I just want to know before I commit the patch if you tested that libglade
> works ok without the packing tag.
> 
> I've tested that glade2 has no problems, so if you say that libglade is also
> ok, I will commit it.
> 
> Thank you for the patch!
> 
> Cheers,
> 
> _______________________________________________
> Glade-devel maillist  -  Glade-devel@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/glade-devel
-- 
Shane Butler <shane_b@users.sourceforge.net>

--Boundary_(ID_Ccn2M7djz72KKzkQS+ClVQ)
Content-type: text/xml; charset=UTF-8; name=glade2-simple.glade
Content-disposition: attachment; filename=glade2-simple.glade
Content-transfer-encoding: 7BIT

<?xml version="1.0" standalone="no"?> <!--*- mode: xml -*-->
<!DOCTYPE glade-interface SYSTEM "http://glade.gnome.org/glade-2.0.dtd">

<glade-interface>

<widget class="GtkWindow" id="window1">
  <property name="visible">True</property>
  <property name="title" translatable="yes">window1</property>
  <property name="type">GTK_WINDOW_TOPLEVEL</property>
  <property name="window_position">GTK_WIN_POS_NONE</property>
  <property name="modal">False</property>
  <property name="resizable">True</property>
  <property name="destroy_with_parent">False</property>

  <child>
    <widget class="GtkButton" id="button1">
      <property name="visible">True</property>
      <property name="can_focus">True</property>
      <property name="label" translatable="yes">button1</property>
      <property name="use_underline">True</property>
      <property name="relief">GTK_RELIEF_NORMAL</property>
    </widget>
  </child>
</widget>

</glade-interface>

--Boundary_(ID_Ccn2M7djz72KKzkQS+ClVQ)
Content-type: text/xml; charset=UTF-8; name=glade3-simple.glade
Content-disposition: attachment; filename=glade3-simple.glade
Content-transfer-encoding: 7BIT

<?xml version="1.0"?>
<glade-interface>
  <widget class="GtkWindow" id="window1">
    <property name="tooltip"></property>
    <child>
      <widget class="GtkButton" id="button1">
        <property name="tooltip"></property>
      </widget>
      <packing/>
    </child>
  </widget>
</glade-interface>

--Boundary_(ID_Ccn2M7djz72KKzkQS+ClVQ)--