[Glade-devel] Small HIG patch for GtkFileChooser

[Archit Baweja]

Ouch :-)

Here it is

? autom4te-2.53.cache
? bah
? bah.glade3
? stamp-h1
? test.glade
? test.glade3
? src/bah
? src/bah.glade3
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/glade3/ChangeLog,v
retrieving revision 1.293
diff -u -r1.293 ChangeLog
--- ChangeLog	16 May 2004 19:40:04 -0000	1.293
+++ ChangeLog	17 May 2004 16:09:49 -0000
@@ -1,3 +1,9 @@
+2004-05-17  Archit Baweja  <bighead@users.sourceforge.net>
+
+	* src/glade-utils.c (glade_util_file_chooser_new): the order of buttons
+	should be Cancel then Open/Save, not the other way around (as per HIG)
+	Fixed :-).
+
 2004-05-16  Joaquin Cuenca Abela  <e98cuenc@yahoo.com>
 
 	* src/glade-menu-editor.c, glade-project-window.c, glade-utils.[ch]:
Index: src/glade-utils.c
===================================================================
RCS file: /cvs/gnome/glade3/src/glade-utils.c,v
retrieving revision 1.26
diff -u -r1.26 glade-utils.c
--- src/glade-utils.c	16 May 2004 19:40:04 -0000	1.26
+++ src/glade-utils.c	17 May 2004 16:09:50 -0000
@@ -308,8 +308,9 @@
 {
 	g_assert (action == GTK_FILE_CHOOSER_ACTION_OPEN || action == GTK_FILE_CHOOSER_ACTION_SAVE);
 	return gtk_file_chooser_dialog_new (title, parent, action,
+					    GTK_STOCK_CANCEL,
+					    GTK_RESPONSE_CANCEL,
 					    action == GTK_FILE_CHOOSER_ACTION_OPEN ? GTK_STOCK_OPEN : GTK_STOCK_SAVE, GTK_RESPONSE_OK,
-					    GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
 					    NULL);
 }
 


Christian Neumair <chris@gnome-de.org> writes:

> Am Mo, den 17.05.2004 um 12:10 Uhr -0400 schrieb Archit Baweja:
> > Hey
> > 
> > The Open and Save As dialog boxes have the Cancel button after the Open/Save As
> > buttons. Violates HIG. This patch fixes it. Give me a go ahead to commit =D
> 
> You forgot the patch ;).
> 
> regs,
>  Chris
> 
> _______________________________________________
> Glade-devel maillist  -  Glade-devel@lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/glade-devel
> 
> 

-- 
Homepage: http://puggy.symonds.net/~bighead/
Projects:
	http://peacock.sourceforge.net/
	http://ore.rubyforge.net/