[Glade-devel] [glade3, patch] load library module before calling *_get_type ()

[Joaquin Cuenca Abela]

--- Tommi Komulainen <tommi.komulainen@nokia.com>
wrote:
> On Fri, 2004-01-09 at 16:51, ext Joaquin Cuenca
> Abela wrote:
> > 
> > That makes perfect sense to me.  If none else
> > disagrees, feel free to commit a patch with your
> > suggested changes, which should equal to your
> earliest
> > patch + this change.
> 
> I'll rather attach a followup patch to be applied
> after the previous
> one.  They are solving slightly different issues. 
> The first one simply
> fixed the library loading.  This one makes it more
> general and
> convenient (unfortunately library="gnomeui-2" is
> pretty useless without
> wrappers)

It looks ok after a quick revision.  The only thing to
change will be the test for 

if (!path)
{
	g_warning (_("Not enough memory."));
	return NULL;
}

I know that we do it, and that it was mainly me that
introduced that kind of tests, but I realized not long
ago that g_malloc & friends exit if there is not
enough memory, so after a memory allocation you're
assured to get your memory or die.

Existent tests for not enough memory should be
removed, and we should not add new ones.

Other than that, it looks ok.

I will commit this evening.

Cheers,



=====
Joaquin Cuenca Abela
e98cuenc at yahoo dot com

__________________________________
Do you Yahoo!?
Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
http://hotjobs.sweepstakes.yahoo.com/signingbonus