[Glade-devel] [glade-3] Problem with undo/redo menu getting too long

[Joaquin Cuenca Abela]

--- Damon Chaplin <damon@karuna.uklinux.net> wrote:
> 
> Currently glade_command_set_property() does this:
> 
>         value_name =
> glade_property_class_make_string_from_gvalue
> (property->class, pvalue);
> 
>          cmd->description = g_strdup_printf
> (_("Setting %s of %s to
> %s"),
>                                            
> property->class->name,
>                                            
> gwidget->name,
>                                            
> value_name);
> 
> 
> Unfortunately value_name can be quite long, e.g. for
> flags or for string
> properties. So the Undo/Redo menu items can become
> much too long.
> 
> I'd suggest passing a 'gboolean for_undo_menu' flag
> to
> glade_property_class_make_string_from_gvalue(). For
> long properties like
> flags and strings it would just return NULL. In that
> case the
> description would be set like this (i.e. without the
> final 'to %s'):

It seems more sensible to me to chop the string
representation of the property in
glade_command_set_{property,name} if it's too long,
and in this case just display the begin ... end of the
property.

Cheers,


=====
Joaquin Cuenca Abela
e98cuenc at yahoo dot com


	
		
__________________________________
Do you Yahoo!?
Yahoo! Photos: High-quality 4x6 digital prints for 25¢
http://photos.yahoo.com/ph/print_splash