[forms-devel] Should the Popped event be raised when PopToRoot is called.

[Jason Smith]

It's fine, during the review period any issues with the proposal will be
discussed/hashed out, however for the moment nothing about it strikes me as
bad. I should probably add some details in there about the alternatives
already discussed on this thread.

On Thu, May 26, 2016 at 2:35 PM, Johan Karlsson <johan.kson at gmail.com>
wrote:

> Hi!
>
> I'm rereading the evolution process at
> https://github.com/xamarin/xamarin-evolution/blob/master/process.md again
> and I'm suddenly feeling that my proposal perhaps isn't as detailed as you
> guys would have wished it to be. I didn't circulate the proposal in the
> mailing list and such.
>
> Should I withdraw the proposal or do you want to continue to review it
> anyway?
>
> My main concern is not to waste the review teams time in vain. Having that
> said, I really do think that the feature should be implemented. :)
>
> Best regards
>
> // Johan
>
> 2016-05-25 18:29 GMT+02:00 Jason Smith <jason.smith at xamarin.com>:
>
>> Thank you Johan, I have scheduled the review.
>>
>> Jason
>>
>> On Wed, May 25, 2016 at 3:13 AM, <johan.kson at gmail.com> wrote:
>>
>>> PR for proposal created.
>>>
>>> https://github.com/xamarin/xamarin-evolution/pull/2
>>>
>>> Skickat från min iPhone
>>>
>>> 24 maj 2016 kl. 19:45 skrev Jason Smith <jason.smith at xamarin.com>:
>>>
>>> Just realize I accidentally the entire conversation off the mailing list.
>>>
>>> I hate mailing lists for this reason...
>>>
>>> On Tue, May 24, 2016 at 10:37 AM, Jason Smith <jason.smith at xamarin.com>
>>> wrote:
>>>
>>>> We could do that yes, it would however be "hidden" API because we
>>>> couldn't actually change the signature of the event. If you know about it
>>>> and are will to cast though that is probably the best solution. Consider
>>>> proposing a spec to the https://github.com/xamarin/xamarin-evolution
>>>> repo :)
>>>>
>>>> On Tue, May 24, 2016 at 10:17 AM, <johan.kson at gmail.com> wrote:
>>>>
>>>>> What about adding to the event args? I do understand that one simply
>>>>> can't add stuff without carefully considering it so I will not argue about
>>>>> that.
>>>>>
>>>>> This wouldn't break anything.
>>>>>
>>>>> class PopToRootEventArgs : NavigationEventArgs
>>>>> {
>>>>>     public List<Page> PoppedPages {...}
>>>>> }
>>>>>
>>>>> I will not trouble you again with this, just want to make sure you
>>>>> considered the event args option. :)
>>>>>
>>>>> // Johan
>>>>>
>>>>> Skickat från min iPhone
>>>>>
>>>>> 24 maj 2016 kl. 19:02 skrev Jason Smith <jason.smith at xamarin.com>:
>>>>>
>>>>> We could consider another event, however it does result in some
>>>>> ugliness for consumers, it just makes the entire process much uglier in
>>>>> general to use.
>>>>>
>>>>> We need to weight waiting for quirks against doing this now and being
>>>>> saddled with a bad API forever :/
>>>>>
>>>>> On Tue, May 24, 2016 at 9:37 AM, <johan.kson at gmail.com> wrote:
>>>>>
>>>>>> Hi!
>>>>>>
>>>>>> I figured that might be the case. Could we find an alternative way?
>>>>>> Adding another event or extension point without cluttering the architecture?
>>>>>>
>>>>>> Perhaps adding an property to the event args passed in PoppedToRoot
>>>>>> that contains a list of pages that are dismissed? This wouldn't break any
>>>>>> existing behavior and would be nicely tucked away in the only place where
>>>>>> this would matter.
>>>>>>
>>>>>> In my case I need to loop through them to deregister stuff.
>>>>>>
>>>>>> Best regards.
>>>>>>
>>>>>> // Johan
>>>>>>
>>>>>> Skickat från min iPhone
>>>>>>
>>>>>> 24 maj 2016 kl. 18:11 skrev Jason Smith <jason.smith at xamarin.com>:
>>>>>>
>>>>>> Unfortunately this may result in behavioral changes which could break
>>>>>> some users apps. This means this suggestion is more or less dead in the
>>>>>> water until we get our quirks mode developed.
>>>>>>
>>>>>> Jason
>>>>>>
>>>>>> On Tue, May 24, 2016 at 8:41 AM, Johan Karlsson <johan.kson at gmail.com
>>>>>> > wrote:
>>>>>>
>>>>>>> Hi!
>>>>>>>
>>>>>>> My summary and suggested conceptual change is in this post
>>>>>>>
>>>>>>> https://forums.xamarin.com/discussion/66155/poptoroot#latest
>>>>>>>
>>>>>>> Good idea? Bad idea?
>>>>>>>
>>>>>>> Best regards
>>>>>>>
>>>>>>> // Johan
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> forms-devel mailing list
>>>>>>> forms-devel at lists.xamarin.com
>>>>>>> http://lists.ximian.com/mailman/listinfo/forms-devel
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/forms-devel/attachments/20160526/0f22f7df/attachment.html>