[forms-devel] Review Announcement: SE-0002: Additional EventArgs On PoppedToRoot

[Jason Smith]

I find no particular issue for this change other than it being a completely
hidden API. Users who know about it can use it, but there is nothing which
would enable a new user to find it. In the future, if we ever can
(currently not looking likely), we could then change the event signature to
expose the new event args.

Unless objections are raised, I am going to approve this review.

Jason

On Wed, Jun 1, 2016 at 10:42 AM, Jason Smith <jason.smith at xamarin.com>
wrote:

> Hello Xamarin community,
>
> The review of "Additional EventArgs On PoppedToRoot" begins now and runs
> through June 3, 2016. The proposal is available here:
>
>
> https://github.com/xamarin/xamarin-evolution/blob/master/xamarin.forms/proposals/0002-additional-event-args-on-popped-to-root.md
> <https://github.com/xamarin/xamarin-evolution/blob/master/proposals/NNNN-proposal.md>
>
> Reviews are an important part of the Xamarin evolution process. All
> reviews should be sent to the xamarin-evolution mailing list at
>
> https://lists.xamarin.org/mailman/listinfo/xamarin-evolution
>
> or, if you would like to keep your feedback private, directly to the
> review manager. When replying, please try to keep the proposal link at the
> top of the message:
>
> Proposal link:
>
> http://linkToProposal
>
> Reply text
>
> Other replies
>
> What goes into a review?
>
> The goal of the review process is to improve the proposal under review
> through constructive criticism and, eventually, determine the direction of
> Xamarin. When writing your review, here are some questions you might want
> to answer in your review:
>
>    - What is your evaluation of the proposal?
>    - Is the problem being addressed significant enough to warrant a
>    change to Xamarin?
>    - Does this proposal fit well with the feel and direction of Xamarin?
>    - If you have used other languages or libraries with a similar
>    feature, how do you feel that this proposal compares to those?
>    - How much effort did you put into your review? A glance, a quick
>    reading, or an in-depth study?
>
> More information about the Xamarin evolution process is available at
>
> https://github.com/xamarin/xamarin-evolution/blob/master/process.md
>
> Thank you,
>
> -Jason Smith
>
> Review Manager
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/forms-devel/attachments/20160603/00ac0e20/attachment.html>